[vlc-devel] [PATCH 1/2] audio_filter: SOFAlizer new module

[David Fuhrmann]

Hi Wolfgang,

> Am 17.04.2015 um 14:33 schrieb Wolfgang Hrauda <wolfgang.hrauda at gmx.at>:
> 
> Am 14.04.2015 um 18:38 schrieb David Fuhrmann <david.fuhrmann at gmail.com>:
> 
>> Hi,
> Hi David,
> 
>> 
>>> +vlc_module_begin ()
>>> +    set_description( N_("SOFAlizer") )
>>> +    set_shortname( N_("SOFAlizer") )
>>> +    set_capability( "audio filter", 0)
>>> +    set_help( HELP_TEXT )
>>> +    add_loadfile( "sofalizer-filename1", "", FILE1_NAME_TEXT, FILE_NAME_LONGTEXT, false)
>>> +    add_loadfile( "sofalizer-filename2", "", FILE2_NAME_TEXT, FILE_NAME_LONGTEXT, false)
>>> +    add_loadfile( "sofalizer-filename3", "", FILE3_NAME_TEXT, FILE_NAME_LONGTEXT, false)
>> 
>> I do not really like such kind of stuff. Why three file names? If you want to switch to a fourth file, you are screwed. And with this its really hard to integrate it in any UI (for providing on-the-fly change of the file).
> Thanks a lot for your thoughts on this!
> 
> Just to make sure, we're talking about the same thing, I'd like to explain, what we are doing and why:
> The SOFA files contain HRTF data which are very individual to each person. And the psychoacoustic effect of the binaural rendering ( which is done in our module) is very sensitive to what HRTF set you use. Therefore it is absolutely important to be able to compare a few HRTF sets on-the-fly without interruption in the playback. E.g., going through a file open dialogue for changing files, would be a too long interruption of playback,

Well, an open dialog in the GUI does not pause any audio playback.

> because the auditive impression would already vanish, making an accurate comparison impossible.
> E.g. if you had your own HRTF data set measured, you might need to compare different post-processing versions of it. And if you don't have your own HRTF set, you need the select one that gives you a good effect, which is quite tricky and unpredictable.
> 
> Therefore, three SOFA files (each containing one HRTF set) can be defined in the advanced settings. All their data is loaded during opening of the audio module. This allows for almost seamless switching between the three different HRTF sets in the UI.

How do you plan to do the switching? Just a combo box to select variant1/2/3?

> I agree that three is an arbitrary choice, but I think in this context it is a good choice.
> 
> 
>> Did you tried one variable, and on-the-fly reconfiguration in a variable callback? I think this would be better, and thats what variable callbacks are for.
> I admit I do not understand exactly, how this would work!? How would the user change between files, then? Would it mean that a file open dialogue would pop up each time the user wants to change to a different file?

This is not about how you implement the GUI. Even with one variable for the „current HRTF file", you can still implement a combo box in the GUI, for selecting predefined presets, instead of an open dialog.

> Keeping in mind what I wrote above (our goal is seamless switching between files during playback), do you think the variable callback approach would work?

I understand your need here. Question is: How long does it take to load and parse such an HRTF file? Its probably quite fast, and then it should be fine to use a callback. I mean who cares if the switch to the new HRTF file happens only 20 ms after you clicked something in the GUI.

Best,
David

> 
> Thanks for your help and best regards,
> Wolfgang
> 
> 
> 
>> 
>> Best regards,
>> David
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel