[vlc-devel] [PATCH] core: add a callback to init/release data for picture pool of opaque formats

[Steve Lhomme]

On Mon, Apr 20, 2015 at 3:43 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> Le 2015-04-20 16:25, Steve Lhomme a écrit :
>>
>> a gargabe collector callback is introduced for the global release
>> after all pictures are released from the pool
>
>
> I still think this is completely useless. And on top of that, it's very
> invasive.


I'm open to other working solutions. I think it makes sense that a
pixel format comes with the instructions on how to handle it pixels.
The tricky part in the case of D3D9 compared to the others is that the
surface passed from the decoder to the vout need to be created from
the same D3D9 device handle. So this handle needs to be shared one way
or another between the decoder and the vout.

First I went with each individual picture_t being passed some blob to
handle extra init. But in the end we allocate picture_t in a pool so a
"pool_setup_t" made more sense.

I think in general some deeper changes could be made to picture_t and
picture_pool_t so they don't assume that their data are in planes
allocated in CPU memory. But for now this tweak should do.