[vlc-devel] [PATCH] direct3d9: more better warnings

Tristan Matthews le.businessman at gmail.com
Mon Apr 20 16:25:46 CEST 2015


On Mon, Apr 20, 2015 at 8:13 AM, Steve Lhomme <robux4 at videolabs.io> wrote:

> ---
>  modules/video_output/msw/direct3d9.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/modules/video_output/msw/direct3d9.c
> b/modules/video_output/msw/direct3d9.c
> index d38f3a3..93f2e07 100644
> --- a/modules/video_output/msw/direct3d9.c
> +++ b/modules/video_output/msw/direct3d9.c
> @@ -1006,6 +1006,7 @@ static int Direct3D9CreatePool(vout_display_t *vd,
> video_format_t *fmt)
>
>      picture_t *picture = picture_NewFromResource(fmt, &resource);
>      if (!picture) {
> +        msg_Err(vd, "Failed to create a picture from resources.");
>          IDirect3DSurface9_Release(surface);
>          free(picsys);
>          return VLC_ENOMEM;
> @@ -1483,7 +1484,7 @@ static int Direct3D9ImportPicture(vout_display_t *vd,
>      hr = IDirect3DDevice9_StretchRect(sys->d3ddev, source, NULL,
> destination, NULL, D3DTEXF_LINEAR);
>      IDirect3DSurface9_Release(destination);
>      if (FAILED(hr)) {
> -        msg_Dbg(vd, "Failed IDirect3DTexture9_GetSurfaceLevel: 0x%0lx",
> hr);
> +        msg_Dbg(vd, "Failed IDirect3DDevice9_StretchRect: source 0x%p
> 0x%0lx", source, hr);
>          return VLC_EGENERIC;
>      }


Nit: It's "better warnings", not "more better warnings"

Best,
Tristan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20150420/b441a5f6/attachment.html>


More information about the vlc-devel mailing list