[vlc-devel] [PATCH] DXVA2: output an opaque pixel format with D3D9 surfaces internally

[Steve Lhomme]

On Mon, Apr 20, 2015 at 4:18 PM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> On 20 Apr, Steve Lhomme wrote :
>> +/* DXVA2 opaque video surface for use with D3D9 */
>> +#define VLC_CODEC_DXVA_N_OPAQUE  VLC_FOURCC('D','X','A','9')
>> +#define VLC_CODEC_DXVA_Y_OPAQUE  VLC_FOURCC('D','X','Y','9')
>> +#define VLC_CODEC_DXVA_I_OPAQUE  VLC_FOURCC('D','X','I','9')
>
> I don't see the need of that.

A chroma int doesn't hold information about what the surface contains.
And for DXVA we currently handle 3 different kind of pixel formats.

When we use a picture_t we can recover with pixel format is used in
the surface. But when we init the vout all we get is a video_format_t
that doesn't contain enough info about the D3DFORMAT that should be
used.

It may work if direct rendering is used because the vout will not
allocate a display surface itself. Just the scene texture.

I'll send an updated patch.

> Opaque is opaque, not tied to a pixel format.
> It should hold something for IDirect3D9Surface *, nothing pixel
> specific.
>
>> +    { { VLC_CODEC_DXVA_N_OPAQUE, VLC_CODEC_DXVA_Y_OPAQUE, VLC_CODEC_DXVA_I_OPAQUE, },
>> +                                                FAKE_FMT() },
>> +
>
> With my kindest regards,
>
> --
> Jean-Baptiste Kempf
> http://www.jbkempf.com/ - +33 672 704 734
> Sent from my Electronic Device
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel