[vlc-devel] [PATCH] avcodec: reuse hw acceleration if possible

Rémi Denis-Courmont remi at remlab.net
Tue Apr 21 11:57:50 CEST 2015

Le 2015-04-21 12:44, Steve Lhomme a écrit :
> On Tue, Apr 21, 2015 at 11:38 AM, Rémi Denis-Courmont
> <remi at remlab.net> wrote:
>> Le 2015-04-21 12:32, Steve Lhomme a écrit :
>>> Checking the profile should be added to both,
>>> regardless of this patch.
>> I must disagree.
> Currently if vlc_va_Setup() is called and the dimensions are the 
> same,
> they just set their output values and return.

vlc_va_Setup() is working around a bug in libavcodec, whereby the 
dimension of the pictures were not provided in get_format(). I am not 
even sure if the bug still exists. Indeed, if vlc_va_Setup() fails, you 
are utterly _screwed_ - you will not get any picture buffers. 
vlc_va_Setup() is a bug in itself.

Rémi Denis-Courmont

More information about the vlc-devel mailing list