[vlc-devel] [PATCH] DXVA2: don't use the decoder if the profile is not supported

Jean-Baptiste Kempf jb at videolan.org
Tue Apr 21 18:20:28 CEST 2015


On 21 Apr, Steve Lhomme wrote :
> On Tue, Apr 21, 2015 at 6:15 PM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> > Le 21/04/2015 13:11, Steve Lhomme a écrit :
> >>
> >> +    { "H.264 variable-length decoder, film grain technology",
> >> &DXVA2_ModeH264_F,                      AV_CODEC_ID_H264,
> >> FF_PROFILE_H264_HIGH },
> >
> >
> > If you could use the defines from h264_nal.h, that'd be nice.
> > I would rather that you use a mask of supported profiles.
> >
> >> +static bool profile_supported(const dxva2_mode_t *mode, int
> >> i_src_profile)
> >> +{
> >
> >
> > And that should simplify that one function.
> 
> But are h264_nal.h and h264_get_profile_level() part of the core or
> that would imply dependency on another module ?

You can add them in the .am files.
To use the header, you can just include it.

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device



More information about the vlc-devel mailing list