[vlc-devel] [RFC PATCH 1/2] packetizer: h264: also update dec extra from pf_packetize

Rémi Denis-Courmont remi at remlab.net
Wed Apr 22 11:25:08 CEST 2015

Le 2015-04-22 10:04, Thomas Guillem a écrit :
> There is first a limitation to fix in src/input/decoder.c: the extra
> will be changed only one time, see "if( p_packetizer->fmt_out.i_extra 
> &&
> !p_dec->fmt_in.i_extra )"
> Maybe pf_packetize should return a boolean indicating if format 
> changed.

I don't think that's how it should work. Extra data should not change; 
it is primarily intended for out-of-band codec parameters (such as SDP 
fmtp field for RTP). Muxers and RTP stream output would not cope with 
changing extra data, and probably not all decoders either. How would the 
decoder even know that it needs to reread the data?

It seems to me that you are trying to have the packetizer match bugs in 
your decoder.

Rémi Denis-Courmont

More information about the vlc-devel mailing list