[vlc-devel] [PATCH] DXVA2: lock the buffer pool when getting/releasing a buffer (v4)

Rémi Denis-Courmont remi at remlab.net
Wed Apr 22 19:23:51 CEST 2015

Le mercredi 22 avril 2015, 16:15:49 Steve Lhomme a écrit :
> You can look at vaapi.c which uses similar "asymmetrical" calls. The
> only difference is that he lock is always there, even if only 1 thread
> will be used.

Sigh. In principles, b_thread_safe_callbacks means that get_buffer2 (so Get()) 
is thread-safe. Release() should always be thread-safe.

In practice, b_thread_safe_callbacks is always true because HAVE_AVCODEC_MT is 
always defined, because FF_THREAD_FRAME is always defined.

So the if-statement is useless and confusing at best.

Rémi Denis-Courmont

More information about the vlc-devel mailing list