[vlc-devel] [PATCH] decoder: fix NULL dereference when video format is updating

Rémi Denis-Courmont remi at remlab.net
Mon Apr 27 18:25:15 CEST 2015


Le lundi 27 avril 2015, 18:08:44 Thomas Guillem a écrit :
> p_owner->p_vout can be set to NULL by decoder_UpdateVideoFormat that can be
> called from a different thread than the decoder one (see avcodec).

If the current reads p_owner->p_vout (at line 861 and also in the calling 
function), then p_owner->p_vout must be read-only.

So this is a bug in avcodec, or a limitation of the decoder core depending on 
your point of view. Either way, the patch does not seem "sufficient" to me.

-- 
Rémi Denis-Courmont
http://www.remlab.net/




More information about the vlc-devel mailing list