[vlc-devel] [PATCH] core: don't do early blending if the vout uses filters

Steve Lhomme robux4 at videolabs.io
Mon Apr 27 18:26:05 CEST 2015


On Mon, Apr 27, 2015 at 5:11 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> Le lundi 27 avril 2015, 16:37:32 Steve Lhomme a écrit :
>> --
>> There's a good chance the input format may not be supported, there's a
>> better chance on the filtered display picture
>
> If Windows no longer needs the "slow" pictures flag, then remove the flag. It is
> not used on any other platform, nor anywhere else.

Only DirectDraw seems to need it. It's dropping a lot of frames with
"late spu" enabled.

> Otherwise blending onto slow pictures does not seem like a good idea.

Indeed. On the other hand, coming out of DXVA2, that's the only place
where we can actually do it, after the surface has been turned into
planes. So maybe we have to live with that ?

Or when `is_slow` is detected, we may insert a "planes" that would
filter the picture coming out of the decoder into planes the blender
can handle. Then use that as the input format for the display filters.
That means another picture pool with another picture format. Or isn't
it what the `private_pool` is for ? Right now is reserved in the
decoder pool. But with DXVA2 surfaces I don't think it's of any use.

Steve



More information about the vlc-devel mailing list