[vlc-devel] [PATCH] wasapi: if config.h has _WIN32_WINNT we may not have a useful value

[Steve Lhomme]

On Thu, Aug 6, 2015 at 9:29 AM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> You must never change system extension constants after headers. Discussed
> several times already.

There are some forced in config.h like _WIN32_IE so who gets
precedence ? IMO it's the local file, not config.h

> --
> Rémi Denis-Courmont
> Sent from my NVIDIA Tegra-powered device
>
> ----- Reply message -----
> De : "Steve Lhomme" <robux4 at gmail.com>
> Pour : <vlc-devel at videolan.org>
> Objet : [vlc-devel] [PATCH] wasapi: if config.h has _WIN32_WINNT we may not
> have a useful value
> Date : jeu., août 6, 2015 09:40
>
> ---
>  modules/audio_output/wasapi.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/modules/audio_output/wasapi.c b/modules/audio_output/wasapi.c
> index 48f6d95..5e31fc1 100644
> --- a/modules/audio_output/wasapi.c
> +++ b/modules/audio_output/wasapi.c
> @@ -18,11 +18,15 @@
>   * Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
>
> *****************************************************************************/
>
> -#define _WIN32_WINNT 0x600
>  #ifdef HAVE_CONFIG_H
>  # include <config.h>
>  #endif
>
> +#if !defined(_WIN32_WINNT) || _WIN32_WINNT < 0x600
> +# undef _WIN32_WINNT
> +# define _WIN32_WINNT 0x600
> +#endif
> +
>  #define INITGUID
>  #define COBJMACROS
>  #define CONST_VTABLE
> --
> 2.4.5
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>