[vlc-devel] [PATCH 2/2] libvlc: Add API for the compressor filter module

[Rémi Denis-Courmont]

	Hello,

Le vendredi 07 août 2015, 11:50:56 Ronald Wright a écrit :
> This patch adds support for the compressor filter module to the libvlc API.

It was already a bit iffy with the equalizer, but equalization is sort of 
standard. I don´t really why a specific implementation of audio compression 
should be specifically exposed and worse, set in stone, in the LibVLC API.

What if someone comes up with a better compressor algorithm using different 
tuning parameters? We cannot add a specific API for each and every filter. 
This is not tractable in either scale and in leaving room for future changes.

Also the more filters are supported explicitly the more difficult 
implementation of a better generic solution in the future becomes. (This is 
not just theory: this version of the patch conflicts with the equalizer API.) 
IMHO, this patch would set a very bad precedent.

-- 
Rémi Denis-Courmont
http://www.remlab.net/