[vlc-devel] [PATCH 4/4] freetype: apply sub-text-scale factor where possible

Rémi Denis-Courmont remi at remlab.net
Fri Aug 28 20:15:48 CEST 2015


On Friday 28 August 2015 20:10:46 Francois Cartegnie wrote:
> Le 28/08/2015 20:08, Rémi Denis-Courmont a écrit :
> > On Friday 28 August 2015 20:01:31 Francois Cartegnie wrote:
> >> @@ -1225,6 +1241,13 @@ static int Create( vlc_object_t *p_this )
> >> 
> >>      free( psz_fontfile );
> >>      free( psz_monofontfile );
> >> 
> >> +    atomic_init( &p_sys->i_scale_factor, var_InheritInteger( p_filter,
> >> "sub-text-scale") );
> >> +    if( p_filter->p_parent && p_filter->p_parent->p_parent )
> > 
> > WTH is this supposed to mean? Aside from layering violation, that is.
> 
> Audio filters do the same, they create themselves a variable on the
> parent and hook a callback on it.

That´s a bug. Don´t replicate it.

-- 
Rémi Denis-Courmont
http://www.remlab.net/



More information about the vlc-devel mailing list