[vlc-devel] [PATCH 0/8] Introducing 15- and 31-band ISO equalizers

Jean-Baptiste Kempf jb at videolan.org
Wed Dec 2 10:28:17 CET 2015


On 01 Dec, Ronald Wright wrote :
>   Add monotone cubic interpolation support

OK for me.

>   Add utilities for parsing equalizer band strings

OK for me, I still do not like eqz_util name.

>   equalizer: Add support for extra sets of ISO bands

OK. but why a string_list and not an integer_list for the variable.
Rémi?

>   Qt: Add support for extra sets of equalizer ISO bands

OK. int type should have a more explicit name, but rest is good.

>   lua: Update equalizer support

OK.

>   http lua: Update to match updated equalizer support in Lua backend

OK.

>   macosx: Adapt to new equalizer code with extra sets of ISO bands

OK.

>   libvlc: Adapt to new equalizer code with extra sets of ISO bands

OK.

Waiting for Rémi's approval.

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device


More information about the vlc-devel mailing list