[vlc-devel] [PATCH 1/4] poll: only wait and call WSAEnumNetworkEvents() if select() reported nothing

Steve Lhomme robux4 at gmail.com
Thu Dec 3 07:29:08 CET 2015


On Wed, Dec 2, 2015 at 11:25 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> Seems OK
>
> but at this late hour and after the VideoLAN pikkujoulu, FWIW.

It works better than before but I still got issues where it wouldn't
send again. It may be broken by design because we keep the event for
when we can't read anymore. Thus getting a free extra send() when
select() says we shouldn't. We should receive a WSAEWOULDBLOCK on the
send(). It's handled in many places but maybe not all. But there are
at least some sequences of timing/calls that end up in infinite
waiting (alertable though). I mostly get this at the beginning of
streaming, with a big burst of data, and rarely midstream.

At this point I'd like to investigate the push/pop of routines to
execute in vlc_cancel_self. For now that would be Windows only. If
it's atomic it shouldn't be a big deal.

> --
> Rémi Denis-Courmont
> http://www.remlab.net/
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list