[vlc-devel] [PATCH] test: Provide tests for our strnstr implementation

Hugo Beauzée-Luyssen hugo at beauzee.fr
Wed Dec 9 18:34:07 CET 2015


On 12/09/2015 06:12 PM, Rémi Denis-Courmont wrote:
> On Wednesday 09 December 2015 18:07:13 Hugo Beauzée-Luyssen wrote:
>> I'm not exactly sure that's the way/place for it, hence the patch.
>
> I´d put it in compat/ or compat/test/.
>
>> Another thing that bothers me is should we even build this when
>> HAVE_STRNSTR == 1 ?
>
> You mean on FreeBSD et al? It does not hurt. We´d check that the
> implementation matches our expectation.
>
Thanks!

Pushed regardless of HAVE_STRNSTRN & in compat/test

Regards,

-- 
Hugo Beauzée-Luyssen


More information about the vlc-devel mailing list