[vlc-devel] [PATCH] demux: mp4: Add support for (unpaletted) raw RGB and GREY video

[Francois Cartegnie]

Le 17/12/2015 23:15, Alex Converse a écrit :
> This fixes playback of the gaming content from derf's video testset

Sounds more correct.

The quicktime spec gives:
grayscale depth = (N - 32) for N = 34, 36 and 40.

Unsure if we have codec support for this. (fmt.video.i_bits_per_pixel ?)

> +                case 32 + 8:
> +                    p_track->fmt.i_codec = VLC_CODEC_GREY;
> +                    break;
> +                case 1: case 2: case 4: case 8:
> +                case 32 + 1: case 32 + 4:
> +                    msg_Err( p_demux, "Unimplemented palletted video format" );

Probably _Dbg or _Warn as this is non fatal for the whole stream,
neither an error in the atom.

> +                    p_track->fmt.i_codec = p_sample->i_type;
> +                    break;
> +                default:
> +                    msg_Err( p_demux, "Unknown raw video format" );

^

> +                    p_track->fmt.i_codec = p_sample->i_type;
> +                    break;
> +            }

Francois