[vlc-devel] [PATCH] bluray: add support for stream input

[Jean-Baptiste Kempf]

On 15 Dec, Petri Hintukainen wrote :
> On ti, 2015-12-15 at 10:22 +0100, Jean-Baptiste Kempf wrote:
> > On 15 Dec, Petri Hintukainen wrote :
> > > +        set_description( N_("BluRay demuxer") )
> > 
> > Do we _need_ a specific translation for this?
> 
> I don't know. This is how it was done with DVD plugin.

Does not mean it was clever, tbh :)

> > Why 2048 ?
> 
> Size of one sector. It could be larger too, but I don't know if it

Makes sense, keep it like this.

> > > -    if (strcmp(p_demux->psz_access, "bluray")) {
> > > -        // TODO BDMV support, once we figure out what to do in
> > > libbluray
> > the TODO is done?
> 
> I don't understand what it means. That check prevents using bluray

OK.

> Removing the check would allow using "vlc d:\", "vlc /some/path", ...,
> but would also add significant overhead to probing. There's nothing
> that needs to be done in libbluray.

OK.

> The check is still in access_demux path. Also, local files still
> require using bluray://... so that access plugin won't be used. It
> would add overhead and prevent interacting with the drive.
> 
> I can add checks for local files later (that would allow ex. "vlc
> /xxx.iso" or "vlc d:\" to start BluRay playback). This patch is just to
> allow playback of remote disc image files (my laptop has limited
> storage space ...).
> 
> Probing for BluRays should also allow BluRay playback directly from GUI
> playlist/directory browser. Currently BluRay image files can be played
> only from command-line. And Open Disc... menu is rather slow to use
> with anything else than the default path.

Well, yes.
We should also have a way to check the folder name (inside the URL or in
the folder) for BDMV/ presence, and we should do the same for .ifo and
DVD/

Our disk probing suxx


With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device