[vlc-devel] [PATCH] DASH Parser

[Francois Cartegnie]

Le 30/01/2015 11:58, Oleksandr Dmukh a écrit :
> Log message:
> /*[PATCH] added baseUrl to segment templates link to*/
> /* test:http://dash.edgesuite.net/dash264/TestCases/5b/1/manifest.mpd 
> <http://dash.edgesuite.net/dash264/TestCases/5b/1/manifest.mpd>*/
> 
> 
> patch.diff
> 
> 
> From 2fe0a98a5f3c46c153cd480367ca5c7487143410 Mon Sep 17 00:00:00 2001
> From: Alex Dmukh <alexdmukh at gmail.com>
> Date: Fri, 30 Jan 2015 11:00:14 +0200
> Subject: [PATCH] added baseUrl to segment templates link to
>  test:http://dash.edgesuite.net/dash264/TestCases/5b/1/manifest.mpd

> +        if((*it)->hasAttribute("duration"))
> +            period->duration.Set(IsoTime((*it)->getAttributeValue("duration")));

Seems indeed duration parsing has gone missing.


> --- a/modules/demux/dash/mpd/Period.h
> +++ b/modules/demux/dash/mpd/Period.h
> @@ -54,7 +54,7 @@ namespace dash
>  
>                  virtual Url getUrlSegment() const; /* reimpl */
>                  virtual mtime_t getPeriodStart() const; /* reimpl */
> -
> +                std::string baseURL;

No string please for that property please. There's a BaseURL class.

BTW, you need to split patches.

Francois