[vlc-devel] [PATCH] wasapi: Delegate cleanup to the audio output

[Hugo Beauzée-Luyssen]

On Mon, Feb 16, 2015, at 12:23 PM, Rémi Denis-Courmont wrote:
> Le 2015-02-16 14:07, Hugo Beauzée-Luyssen a écrit :
> > ---
> >  modules/audio_output/mmdevice.c | 9 +++++++++
> >  modules/audio_output/mmdevice.h | 8 ++++++++
> >  modules/audio_output/wasapi.c   | 5 ++---
> >  modules/audio_output/winstore.c | 7 +++++++
> >  4 files changed, 26 insertions(+), 3 deletions(-)
> 
> MMDevice cannot assume that the activated object is an IAudioClient. If 
> it did,  there would be REFIID parameter. Ergo, the patch makes no sense 
> to me.

This is assumed so far, hence I took the liberty of keeping this
assumption.

> Besides, the audio output can already specify custom COM callbacks if 
> it so required. No changes are necessary to the existing stream 
> interface.
> 
I'm not sure to get what you mean.

Since it's not included in the patch, the rationale is that mmdevice
create a new device for every playback, which isn't true for winstore.
Since the devices are not instanciated the same way, it seems sensible
to me to let each module decide how to clear those.
This patch is not required, and doesn't fix anything, except having the
initialization of a device in a module, and releasing it in another one.

Regards,

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr