[vlc-devel] [PATCH] wasapi: Delegate cleanup to the audio output

Hugo Beauzée-Luyssen hugo at beauzee.fr
Mon Feb 16 14:36:46 CET 2015


On Mon, Feb 16, 2015, at 02:25 PM, Rémi Denis-Courmont wrote:
> Le 2015-02-16 16:03, Hugo Beauzée-Luyssen a écrit :
> > On Mon, Feb 16, 2015, at 12:23 PM, Rémi Denis-Courmont wrote:
> >> Le 2015-02-16 14:07, Hugo Beauzée-Luyssen a écrit :
> >> > ---
> >> >  modules/audio_output/mmdevice.c | 9 +++++++++
> >> >  modules/audio_output/mmdevice.h | 8 ++++++++
> >> >  modules/audio_output/wasapi.c   | 5 ++---
> >> >  modules/audio_output/winstore.c | 7 +++++++
> >> >  4 files changed, 26 insertions(+), 3 deletions(-)
> >>
> >> MMDevice cannot assume that the activated object is an IAudioClient. 
> >> If
> >> it did,  there would be REFIID parameter. Ergo, the patch makes no 
> >> sense
> >> to me.
> >
> > This is assumed so far,
> 
> No. As a matter of fact, it is not.
> 

My bad then, I though it was since the output pointer is then stored as
a IAudioClient* and uses methods from IAudioClient interface.

Regards,

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr



More information about the vlc-devel mailing list