[vlc-devel] [PATCH] wasapi: Delegate cleanup to the audio output

Rémi Denis-Courmont remi at remlab.net
Mon Feb 16 15:46:39 CET 2015


Le 2015-02-16 16:03, Hugo Beauzée-Luyssen a écrit :
> Since it's not included in the patch, the rationale is that mmdevice
> create a new device for every playback, which isn't true for 
> winstore.

MMDevice instantiates a device only at start or when changing device, 
but you probably meant client rather than device. Then I doubt that 
instantiating the audio client only once is correct. As far as I know, 
an application is not supposed to instantiate a client if it is not 
actively playing or recording audio.

> Since the devices are not instanciated the same way, it seems 
> sensible
> to me to let each module decide how to clear those.

Even then, there would be no need to alter the interface between the 
audio output and the aout stream. The audio output could already provide 
custom callbacks as things stand. This is not desirable because it would 
make it dependant on the activated IID though.

-- 
Rémi Denis-Courmont



More information about the vlc-devel mailing list