[vlc-devel] [PATCH 2/2] demux: asf: do ES audio selection for mms (fix #8797, #3400, #3797)

[David Glaude]

Dear,

I had the hope this behaviour change relate to a source code change that
month in one of those two files "modules/access/mms/mmsh.c" and
"modules/demux/asf/asf.c".
Just for that last file, there were 41 commits and each or everyone of
those (or a combo) could have break things for me.

Except rebuilding commit after commit until it break, I don't really see
how to find out what went wrong.
I assume all those changes made sense to the author and he had something to
test against.

I'll quickly check the code of those patch to see if I can make some sense
of them.

What other approach would you suggest?

David Glaude

Those are the changes in that time range:
http://www.m2x.nl/videolan/vlc/commits/2a310e14227b7cab441ee5128757a27b57f0b9a7/modules/demux/asf/asf.c

09 Dec, 2013 3 commits
    08b4ccaa9   demux: asf: trigger dialog on drm streams
    fe5e4ac18   demux: asf: avoid truncation on malloc
    c4611bcd8   demux: asf: fix double declaration (cid 1135582)

08 Dec, 2013 3 commits
    15c86584b   demux: asf: check for int overflow
    458c4a5e3   demux: asf: fix signedness
    28b947459   demux: asf: fix signedness in language index

07 Dec, 2013 8 commits
    abb20fc36   demux: asf: use INT64_MAX
    d28dedab8   demux: asf: don't update PCR until preroll is done
    8e7a55dd8   demux: asf: use send time as base time for pcr (fix #6662,
#8795) ...
    882f2d611   demux: asf: only substract preroll from presentation time
and duration ...
    c3ae02a6d   demux: asf: decode payload extension ...
    e89887356   demux: asf: fix time conversion ...
    6ac205bb7   demux: asf: fix computing pts/dts with deltas on sub
payloads ...
    6fb815bbf   demux: asf: Use pts as track time instead of dts ...

04 Dec, 2013 2 commits
    5b8529385   demux: asf: flush remaining tail data (fix #5356)
    3b7a8af42   demux: asf: define MAX_ASF_TRACKS

03 Dec, 2013 3 commits
    01e03b9a0   demux: asf: correctly flag invalid time
    bc5a9b1b9   demux: asf: reset PCR on seek
    adf378a9c   demux: asf: wait keyframe on index seek too ...

02 Dec, 2013 2 commits
    0a3cb49bf   demux: asf: fix keyframe waiting after a seek (fix #6647)
...
    701602135   demux: asf: remember extended stream parameters for tracks

27 Nov, 2013 1 commit
    f5ef14fd4   demux: asf: add check in control (CID 1132753) ...

26 Nov, 2013 4 commits
    cd3efe2dc   demux: asf: seek seekable
    991b40676   demux: asf: ignore empty sub-payloads (fix #9990)
    b43f53f92   demux: asf: fix seek boundaries
    b5bffbb29   demux: asf: fix wrong allocation size ...

25 Nov, 2013 2 commits
    52dc92775   demux: asf: fix variable length reading. ...
    51785680c   demux: asf: fix overflow in seek

23 Nov, 2013 2 commits
    9a0de97a7   demux: asf: do bitrate mutual exclusion
    4dbcaaa57   demux: asf: follow track exclusion list (fix #3796)

22 Nov, 2013 2 commits
    23445cd54   demux: asf: reject DRM'ed files ...
    58c8f9f3c   demux: asf: preroll to seek time from index keyframes (fix
#7890)

15 Nov, 2013 1 commit
    1c7b3420e   demux: asf: fix multiple compressed payload regression (fix
#9846) ...



2015-02-17 10:23 GMT+01:00 Rémi Denis-Courmont <remi at remlab.net>:

> Le 2015-02-17 11:34, David Glaude a écrit :
>
>> The last to work is: vlc-2.2.0-git-20131104-1009-win32.exe OK with
>> 3V+24A
>> The first to fail is: vlc-2.2.0-git-20131209-0039-win32.exe KO no
>> audio on switching language
>>
>
> Seriously, that covers a range of 600-700 different changes... If you want
> to play the blame game, you need to pinpoint a specific change. And you
> cannot do that with nightly builds in any case.
>
> --
> Rémi Denis-Courmont
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20150217/989f7d7c/attachment.html>