[vlc-devel] [PATCH] playlist: Set the playlist input thread before triggering a callback

[Rémi Denis-Courmont]

Le 2015-02-19 16:39, Jonas Lundqvist a écrit :
> Close #13972
> ---
>  src/playlist/thread.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/src/playlist/thread.c b/src/playlist/thread.c
> index b865af8..12a452d 100644
> --- a/src/playlist/thread.c
> +++ b/src/playlist/thread.c
> @@ -235,10 +235,13 @@ static bool PlayItem( playlist_t *p_playlist,
> playlist_item_t *p_item )
>      }
>      free( psz_arturl );
>
> +    PL_LOCK;
> +    p_sys->p_input = p_input_thread;
> +    PL_UNLOCK;
> +

I have a hard time following the playlist logic (or lack thereof). This 
snippet seems very suspicious to me (LOCK SET UNLOCK is almost always 
wrong), but I am unable to check if it is correct or not.

-- 
Rémi Denis-Courmont