[vlc-devel] [PATCH 1/2] contrib: add bpg

Rafaël Carré funman at videolan.org
Wed Jan 7 14:36:33 CET 2015


On 01/07/2015 12:02 AM, Tristan Matthews wrote:
> On Tue, Jan 6, 2015 at 4:43 PM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
>> On 05 Jan, Tristan Matthews wrote :
>>> +     $(APPLY) $(SRC)/bpg/pic.patch
>>
>> Apply that without condition, doubtful.
> 
> Yeah I thought that was dicey, but I'm not sure when I should omit it...win?

I think it should be applied without condition.

On the other hand it would be better to use the flags set by contrib,
which would certainly include -fPIC when needed.

>>> +     cd $< && $(MAKE) libbpg.a
>>> +     mkdir -p $(PREFIX)/include/ && cp $</libbpg.h $(PREFIX)/include/
>>> +     mkdir -p $(PREFIX)/lib/ && cp $</libbpg.a $(PREFIX)/lib/
>>
>> No .pc?
> 
> Nope, I wish.
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
> 



More information about the vlc-devel mailing list