[vlc-devel] [RFC PATCH 6/7] input: preparsing not only for files

[Thomas Guillem]

On Thu, Jan 8, 2015, at 15:18, Rémi Denis-Courmont wrote:
> We don't want to preparse remote items. I think the reasons why are 
> obvious: network traffic/performance, hardware resources (for capture 
> devices), privacy, etc.

Hum... it's not very clear here. I'm rebasing my patches and writing
more comments/commit log.

input_Preparse will be called only if META_REQUEST_OPTION_SCOPE_NETWORK
is set when calling 
playlist_preparser_Push (input_Preparse is only called from
playlist_preparser_Push).
It won't change anything in vlc desktop, since playlist_preparser_Push
is not called with META_REQUEST_OPTION_SCOPE_NETWORK flag. For libvlc,
I'm adding a new libvlc_media_parse function that will allow to specify
SCOPE.


> 
> Le 2015-01-07 14:06, Thomas Guillem a écrit :
> > ---
> >  src/input/input.c | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/src/input/input.c b/src/input/input.c
> > index aa5a835..48e085d 100644
> > --- a/src/input/input.c
> > +++ b/src/input/input.c
> > @@ -2225,11 +2225,8 @@ static int InputSourceInit( input_thread_t 
> > *p_input,
> >      }
> >      else
> >      {
> > -        /* Preparsing is only for file:// */
> >          if( *psz_demux )
> >              goto error;
> > -        if( strcmp( psz_access, "file" ) )
> > -            goto error;
> >          msg_Dbg( p_input, "trying to pre-parse %s",  psz_path );
> >      }
> 
> -- 
> Rémi Denis-Courmont
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel