[vlc-devel] [vlc-commits] contrib: add bpg

[Tristan Matthews]

On Fri, Jan 9, 2015 at 7:45 AM, Rafaël Carré <funman at videolan.org> wrote:
> On 01/08/2015 06:12 PM, Tristan Matthews wrote:
>> On Thu, Jan 8, 2015 at 12:07 PM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
>>>
>>> On 08 Jan, Tristan Matthews wrote :
>>>> +-CFLAGS:=-Os -Wall -MMD -fno-asynchronous-unwind-tables -fdata-sections -ffunction-sections -fno-math-errno -fno-signed-zeros -fno-tree-vectorize -fomit-frame-pointer
>>>> ++CFLAGS+=-Os -Wall -MMD -fno-asynchronous-unwind-tables -fdata-sections -ffunction-sections -fno-math-errno -fno-signed-zeros -fno-tree-vectorize -fomit-frame-pointer
>>>
>>> What is that exactly doing?
>>
>>
>> Without it, CFLAGS (from HOSTVARS_PIC) from bpg/rules.mak weren't
>> taken into account when building libbpg.a...so upon building vlc it
>> would complain that libbpg wasn't compiled with fPIC.
>
> Does $(MAKE) $(HOSTVARS) sets CFLAGS correctly ?

No, $(MAKE) $(HOSTVARS) fails with "config.h: No such file or
directory" whereas $(HOSTVARS) $(MAKE) fails with "recompile with
-fPIC"

Best,
Tristan