[vlc-devel] [PATCH 1/1] opus: handle RTP depayloading (fixes #11938)

[Tristan Matthews]

On Sun, Jan 11, 2015 at 2:53 PM, Ross Finlayson <finlayson at live555.com> wrote:
> IMHO, live555 should reject SDP, or at least rtpmap, with nul clock rate as
> that makes no sense. Otherwise, VLC should skip those.
>
>
> FYI, should the LIVE555 library sees a SDP description with a zero (or
> missing) RTP timestamp frequency, it will set it to some sane non-zero
> value.  So VLC's code should never need to check for this.
>
> In particular, you can remove the test
> if ( tk->fmt.audio.i_rate == 0 )
> from line 979 (the 'Speex' branch) of "live555.cpp", because that will never
> happen.

Yeah this was mentioned earlier in the discussion:
https://mailman.videolan.org/pipermail/vlc-devel/2015-January/100928.html

So if there are no outstanding issues I'll merge the second version of
the patch:
https://patches.videolan.org/patch/6771

Best,
Tristan