[vlc-devel] [PATCH] Fix subtitle downloads by not messing encodings

Felix Paul Kühne fkuehne at videolan.org
Mon Jan 19 19:20:10 CET 2015


Hello Filipe,

> On 18 Jan 2015, at 21:19, Filipe Cabecinhas <vlc at filcab.net> wrote:
> 
> VLC was downloading subtitle files as an NSString and assumed certain
> encodings. This is useless to do in the controller, because VLCKit will,
> eventually, autodetect encodings and “do the right thing”.
> 
> Because of this, some subtitle files (e.g: UTF-16 encoded ones) wouldn't
> work over the network, but would work if copied to the device.

Thanks for the patch! Merged!

Best regards,

Felix


More information about the vlc-devel mailing list