[vlc-devel] Patch: New compat function strtoi(3)

Kamil Rytarowski n54 at gmx.com
Wed Jan 21 10:17:44 CET 2015


Rémi Denis-Courmont wrote:
> Le 2015-01-20 20:48, Kamil Rytarowski a écrit :
> > Locally defined function strtoi in src/config/file.c overlaps with
> > strtoi(3) [1] from NetBSD.
> >
> > I'm attaching a patch adding NetBSD's flavour of the function to
> > compat/, instead of wrapping our own.
> 
> The compat stuff seems OK. The rest seems wrong: it changes the 
> semantics of the configuration parser. It would be far easier to just 
> rename the static function.
> 

I'm OK with both solutions. Possible new function name: strtoi() -> vlc_strtoi().



More information about the vlc-devel mailing list