[vlc-devel] [PATCH] libvlc: expand media player API to reveal full information about titles and chapters

[Rémi Denis-Courmont]

Le lundi 26 janvier 2015, 21:55:53 Felix Paul Kühne a écrit :
> > On 26 Jan 2015, at 21:36, Rémi Denis-Courmont <remi at remlab.net> wrote:
> > 
> > Sorry but to label all this "useful" makes me pretty sure that this is
> > just
> > code written without even looking and thinking.
> 
> Can you please elaborate?

OK, so the time offset is useful, albeit only indirectly, to build a time line. 
The duration is informative. But the rest...

What do you think is the use case for byte offset and length? Seriously? What 
can the application possibly do with them? Did you actually look at what the 
GUIs did with it? Did you actually think about your code before dumping it for 
review?

What does the menu mean in general? What is the use for the application to 
know which of the tracks are the menus? You can use navigation or seeking if 
you want to go (back) to the hypothetical menu. And you can't use the flag as a 
hint for user interaction either.

The names would be useful where they actually exist, not just as numbers as on 
CDs and DVDs. But then they would need to be localized. How do you specify the 
expected language with your proposal?

-- 
Rémi Denis-Courmont
http://www.remlab.net/