[vlc-devel] [PATCH 4/7] Qt: fix memory leaks

[Francois Cartegnie]

Le 03/07/2015 14:45, Hannes Domani a écrit :

Hi,


> diff --git a/modules/gui/qt4/components/open_panels.cpp b/modules/gui/qt4/components/open_panels.cpp
> index 6b88b5e..66b0994 100644
> --- a/modules/gui/qt4/components/open_panels.cpp
> +++ b/modules/gui/qt4/components/open_panels.cpp
> @@ -386,13 +386,15 @@ void DiscOpenPanel::onFocus()
>                  wchar_t psz_name[512] = L"";
>                  GetVolumeInformationW( drive, psz_name, 511, NULL, NULL, NULL, NULL, 0 );
>  
> -                QString displayName = FromWide( drive );
> +                char *psz_drive = FromWide( drive );
> +                QString displayName = psz_drive;

Someone here would say auto casting is evil.

>                  char *psz_title = FromWide( psz_name );
>                  if( !EMPTY_STR(psz_title)) {

Please inline your patchs or use git send-email.

Otherwise looks ok.


Francois