[vlc-devel] [PATCH 1/6] OS/2 needs __STDC_xxx_MACROS even if C++11 mode

[KO Myung-Hun]

Rémi Denis-Courmont wrote:
> Le lundi 06 juillet 2015, 17:03:20 KO Myung-Hun a écrit :
>> ---
>>  include/vlc_fixups.h | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/vlc_fixups.h b/include/vlc_fixups.h
>> index 0a7b2aa..b3e1577 100644
>> --- a/include/vlc_fixups.h
>> +++ b/include/vlc_fixups.h
>> @@ -28,7 +28,8 @@
>>
>>  /* C++11 says there's no need to define __STDC_*_MACROS when including
>>   * inttypes.h and stdint.h. */
>> -#if defined (__cplusplus) && (!defined(HAVE_CXX11) || defined(__MINGW32__))
>> +#if defined (__cplusplus) && \
>> +    (!defined(HAVE_CXX11) || defined(__MINGW32__) || defined(__OS2__))
>>  # ifndef __STDC_FORMAT_MACROS
>>  #  define __STDC_FORMAT_MACROS 1
>>  # endif
> 
> I do not see how it is a property of "OS/2" that your specific version of GCC 
> has broken or incomplete support for C++11.
> 

Good point. However, this is not a problem of gcc, but of libc. Anyway,
there are no compilers enough to compile VLC other than gcc on OS/2. In
addition, even if other compilers can build VLC or libc supports C++11
correctly, the above codes have no problems at all.

> Besides, the C++11 configure test should already address this.
> 

Before, you said that this issue were not a problem of configure. BTW,
now you say that this should be addressed in configure. Any changes of
mind ?

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr