[vlc-devel] [vlc-commits] Handle GET_PARAMETER keepalive responses during PAUSE

[Paul Clark]

On 07/07/15 21:01, Rémi Denis-Courmont wrote:
> Le mardi 07 juillet 2015, 10:35:47 Paul Clark a écrit :
>> vlc | branch: master | Paul Clark <paul at packetship.com> | Wed Jun 24
>> 16:58:08 2015 +0100| [d31f389ed9dbf29e898e9b901b3822ec690e906e] |
>> committer: Jean-Baptiste Kempf
>>
>> Handle GET_PARAMETER keepalive responses during PAUSE
> I really should not need to point out that this did not address earlier review
> comments. Now I know for sure that reviewing live555 patches on my free time
> is a waste.

Please be specific.  I was not trying to solve the apparent Gordian Knot 
around the thread model of the Live555 interface that you were 
discussing with Ross, which is way above my pay grade to solve, even if 
it's soluble; only to fix your (valid) review comments around thread 
safety.  If I have failed to do so, it would be good to know why.

> Leaving aside the issues left from the earlier review, I ought to mention that
> this patch relies on GNU/libc behaviour that few if any other OS run-time
> implements.

Which is?

Thanks

Paul