[vlc-devel] [PATCH 3/6] src: fix compilation of fourcc_gen on OS/2

[Rémi Denis-Courmont]

Le 2015-07-08 09:59, KO Myung-Hun a écrit :
> KO Myung-Hun wrote:
>>
>>
>> Rémi Denis-Courmont wrote:
>>> Le lundi 06 juillet 2015, 17:03:22 KO Myung-Hun a écrit :
>>>> ---
>>>>  configure.ac    | 15 ++++++++++++++-
>>>>  src/Makefile.am |  6 +++---
>>>>  2 files changed, 17 insertions(+), 4 deletions(-)
>>>>
>>>> diff --git a/configure.ac b/configure.ac
>>>> index bf6d416..9751217 100644
>>>> --- a/configure.ac
>>>> +++ b/configure.ac
>>>> @@ -73,7 +73,16 @@ AC_PATH_PROG(YASM, yasm)
>>>>  AC_ARG_VAR([BUILDCC], [Build system C11 or C99 compiler command])
>>>>  AC_PATH_PROGS(BUILDCC, [c11-gcc c11 c99-gcc c99], [false])
>>>>  AS_IF([test "$BUILDCC" = "false"], [
>>>> -  AC_MSG_ERROR([Cannot find native C99 compiler: please define 
>>>> BUILDCC.])
>>>> +  case "${build_os}" in
>>>> +    os2*)
>>>> +      # OS/2 does not have c11* nor c99*. However C99 is suppoted 
>>>> by
>>>> +      # gcc -std=gnu99.
>>>> +      BUILDCC="gcc -std=gnu99"
>>>> +      ;;
>>>> +    *)
>>>> +      AC_MSG_ERROR([Cannot find native C99 compiler: please 
>>>> define
>>>> BUILDCC.]) +      ;;
>>>> +  esac
>>>>  ])
>>>
>
> Updated patches.

I doubt that (ab)using autoconf that way is specified/supported. It 
probably misbehaves when not building natively. Besides it seems to me 
that this is a big and intrincate workaround for a bug in your build 
environment.

-- 
Rémi Denis-Courmont
http://www.remlab.net/