[vlc-devel] [PATCH] src: fix some features not available on Windows App Store versions

[Jean-Baptiste Kempf]

On 20 Jul, Steve Lhomme wrote :
>  #ifdef HAVE_OPEN_MEMSTREAM
>      FILE *stream = open_memstream(&str, &len);
> -#elif defined( _WIN32 )
> +#elif defined(_WIN32) && !VLC_WINSTORE_APP
>      FILE *stream = vlc_win32_tmpfile();

Why? What is missing?

> +#if VLC_WINSTORE_APP
> +    if ((!strncmp(path, "file://{", 8) || path[0] == '{') && strlen(path) > 32)
> +        return strdup( path );
> +    else
> +#endif

This is a hack.

> -#elif defined (_WIN32) && (_WIN32_WINNT >= 0x0601)
> +#elif defined (_WIN32) && (_WIN32_WINNT >= 0x0601) && !defined(VLC_WINSTORE_APP)
>      char *ret = NULL;

Why?

>  {
> +#if VLC_WINSTORE_APP
> +    return NULL;
> +#else

this is incorrect. You must call config_GetShellDir( APP_DATA ); and
its replacement on winRt

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device