[vlc-devel] [vlc-commits] macosx: split main interface class
Felix Paul Kühne
fkuehne at videolan.org
Tue Jul 21 19:53:54 CEST 2015
> On 21 Jul 2015, at 19:11, David Fuhrmann <david.fuhrmann at gmail.com> wrote:
>> ++ (VLCVoutWindowController *)sharedInstance;
>> + at property (readonly, atomic) NSLock *lock;
> AFAIK the lock was introduced to protect access to the sharedInstance call itself. If you move the lock to the object now, we should check if its still needed at all.
It would be great if you could do this since you introduced that lock in the first place.
> For all the callback functions: We should leverage the void* parameter, instead of using the VLCMain singleton everywhere…
Just to make sure that we understand each other. You prefer
void * bridgedSelf = (__bridge void *)self;
var_AddCallback( vlcobject, var, callback, bridgedSelf)
var_AddCallback( vlcobject, var, callback, (__bridge void *)self)
…, correct? :)
>> +- (void)private_resetAndReinitializeUserDefaults;
> Why do you prefix with private? This just looks wrong to me, if it is a private function, it should not occur here…
Laziness, this will disappear again shortly.
More information about the vlc-devel