[vlc-devel] [PATCH] win32: we don't need vlc_WaitForMultipleObjects as we only use single HANDLEs

Rémi Denis-Courmont remi at remlab.net
Tue Jul 21 21:49:55 CEST 2015

Le mardi 21 juillet 2015, 14:29:46 Jean-Baptiste Kempf a écrit :
> Le 21/07/2015 12:31, Rémi Denis-Courmont a écrit :
> > Le 2015-07-21 12:31, Steve Lhomme a écrit :
> >> and the code in vlc_WaitForMultipleObjects was barely common between
> >> the 2 internal calls
> > 
> > I still think this is one step forward two steps backward. And the
> > current mess is entirely due to hackish WinRT support. It was not that
> > messy before.
> Agreed.
> Better idea to remove QueueUserAPC from the vlc_cancel() code?

Maybe but that is not my point. I think vlc_WaitForMultipleObjects() will be 
needed on store going forward due to poll().

I am not concerned about ever broken condition variables though - because that 
affects the desktop too. That might make some or all other issues moot.

Rémi Denis-Courmont

More information about the vlc-devel mailing list