[vlc-devel] [PATCH] demux: adaptative: fix compilation

[Filipe Cabecinhas]

Hi Hugo,

I tried searching on the site, and repo, but couldn’t find anything. What’s the minimum C++ language standard VLC requires, if C++ is available (I see VLC requires C99 *on UNIX*, but haven’t even found that for other systems)?

Just so I don’t complain about stuff like this again (if I remember about standard changes :-) ).

Thank you,

  Filipe

> On Jul 27, 2015, at 01:54, Hugo Beauzée-Luyssen <hugo at beauzee.fr> wrote:
> 
> On 27/07/2015 05:59, Filipe Cabecinhas wrote:
>> How would that be a “fix compilation”?
>> How is being less specific better?
>> 
>>   Filipe
>> 
>>> On Jul 26, 2015, at 20:55, KO Myung-Hun <komh78 at gmail.com> wrote:
>>> 
>>> ---
>>> modules/demux/adaptative/Streams.cpp | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>> 
>>> diff --git a/modules/demux/adaptative/Streams.cpp b/modules/demux/adaptative/Streams.cpp
>>> index 746c065..cad9d7f 100644
>>> --- a/modules/demux/adaptative/Streams.cpp
>>> +++ b/modules/demux/adaptative/Streams.cpp
>>> @@ -34,7 +34,7 @@ using namespace adaptative::logic;
>>> Stream::Stream(demux_t * demux_, const StreamFormat &format_)
>>> {
>>>     p_demux = demux_;
>>> -    type = StreamType::UNKNOWN;
>>> +    type = UNKNOWN;
>>>     format = format_;
>>>     output = NULL;
>>>     adaptationLogic = NULL;
>>> --
>>> 1.9.5
>>> 
> 
> Hi,
> 
> Scoped enumerations aren't part of C++98, so creating an enum doesn't create a "namespace". This patch makes perfect sense as far as I'm concerned.
> 
> Regards,
> 
> -- 
> Hugo Beauzée-Luyssen
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel