[vlc-devel] [PATCH 1/5] va: try to output an opaque chroma first, then a plane-based one

[Steve Lhomme]

On Mon, Jun 1, 2015 at 5:40 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> Le lundi 01 juin 2015, 15:58:04 Steve Lhomme a écrit :
>> ---
>>  modules/codec/avcodec/dxva2.c |  2 +-
>>  modules/codec/avcodec/va.h    |  7 ++++---
>>  modules/codec/avcodec/vaapi.c |  3 ++-
>>  modules/codec/avcodec/vda.c   |  3 ++-
>>  modules/codec/avcodec/video.c | 32 ++++++++++++++++++++++++++------
>>  modules/hw/vdpau/avcodec.c    |  3 ++-
>>  6 files changed, 37 insertions(+), 13 deletions(-)
>
> Surface types are normally converted in video filters, not in decoders.

Well, the old DXVA was doing the plane extraction on the fly from the
"opaque" surface. There is no "conversion" in terms of pixel type.

> As things currently stand, this patch won't work anyway. The other call sites
> for decoder plugins (transcode et al.) do not correctly return an error on
> format update.

I will fix that, and return an error when they don't support a real
opaque format, so that calls are consistent with the goal.

> --
> Rémi Denis-Courmont
> http://www.remlab.net/
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel