[vlc-devel] [PATCH v3] Dim MacBook keyboard backlight during video playback on OSX

Maxime Mouchet max at maxmouchet.com
Tue Jun 2 20:04:25 CEST 2015


> But we found one issue we would like to ask you to fix if possible: Its not good to simply fire threads to change the blacklights. If you try switching fullscreen quickly (just quickly press cmd+f a couple of times), you see the lights repeatedly flashing a couple of seconds even after the animation has been finished.
> We should cancel previous threads before firing a new one. Speaking of that, maybe it makes even sense to get rid of the threads altogether and switch to a timer doing the animation? I assume the system call is fast enough to be executed on the main thread, and you can easily cancel the timer if a new request comes in.

Thanks ! Sure I’ll check to fix that.


More information about the vlc-devel mailing list