[vlc-devel] [PATCH] va: document the extra parameter

[Steve Lhomme]

On Wed, Jun 3, 2015 at 9:54 AM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> Le 2015-06-02 16:56, Steve Lhomme a écrit :
>>
>> ---
>>  modules/codec/avcodec/va.h | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/modules/codec/avcodec/va.h b/modules/codec/avcodec/va.h
>> index 5c4b11d..2d3d30b 100644
>> --- a/modules/codec/avcodec/va.h
>> +++ b/modules/codec/avcodec/va.h
>> @@ -55,6 +55,7 @@ vlc_fourcc_t vlc_va_GetChroma(enum PixelFormat
>> hwfmt, enum PixelFormat swfmt);
>>   * Creates an accelerated video decoding back-end for libavcodec.
>>   * @param obj parent VLC object
>>   * @param fmt VLC format of the content to decode
>> + * @param p_sys picture_sys_t type that will be used with Extract()
>
>
> True but misleading IMO.

Rather than a picture_sys_t we could pass a picture_t, which would
mean checking for correct typing/values a bit safer.

>>   * @return a new VLC object on success, NULL on error.
>>   */
>>  vlc_va_t *vlc_va_New(vlc_object_t *obj, AVCodecContext *,
>
>
> --
> Rémi Denis-Courmont
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel