[vlc-devel] [PATCH 4/5] decoder: add a way to try an other decoder module

[Julian Scheel]

Hi,

Am 03.06.2015 um 17:35 schrieb Thomas Guillem:
> if p-dec->b_try_next is set to true, the current module will be unloaded and a
> next one will be tried.
> ---
>   include/vlc_codec.h |  1 +
>   src/input/decoder.c | 19 +++++++++++++++----
>   2 files changed, 16 insertions(+), 4 deletions(-)
>
> diff --git a/include/vlc_codec.h b/include/vlc_codec.h
> index 8f6f46a..197bda7 100644
> --- a/include/vlc_codec.h
> +++ b/include/vlc_codec.h
> @@ -128,6 +128,7 @@ struct decoder_t
>       decoder_owner_sys_t *p_owner;
>
>       bool                b_error;
> +    bool                b_try_next;

Why would the decoder itself decide whether fallback shall be tried or 
not? Wouldn't it make more sense to let the user decide whether to take 
this approach or not?


-Julian