[vlc-devel] [vlc-commits] fourcc: remove last conflicting FourCC alias

[Rémi Denis-Courmont]

Le vendredi 12 juin 2015, 20:40:37 Jean-Baptiste Kempf a écrit :
> On 12 Jun, Rémi Denis-Courmont wrote :
> > diff --git a/src/misc/fourcc_list.h b/src/misc/fourcc_list.h
> > index dcc9c57..c532066 100644
> > --- a/src/misc/fourcc_list.h
> > +++ b/src/misc/fourcc_list.h
> > @@ -326,7 +326,6 @@ static const staticentry_t p_list_video[] = {
> > 
> >          A("mjpa"),
> >          A("JFIF"),
> >          A("JPGL"),
> > 
> > -        A("LJPG"),
> > 
> >          A("MMJP"),
> >          A("FLJP"),
> >          A("FMJP"),
> > 
> > @@ -350,9 +349,6 @@ static const staticentry_t p_list_video[] = {
> > 
> >      B(VLC_CODEC_LJPG, "Lead Motion JPEG Video"),
> >      
> >          E("Ljpg", "Lead Motion JPEG"),
> > 
> > -    // ? from avcodec/fourcc.c but makes not sense.
> > -    //{ VLC_FOURCC( 'L','J','P','G' ), CODEC_ID_MJPEG,       VIDEO_ES,
> > "Lead Motion JPEG Video" }, -
> 
> This (or the previous) breaks LJPG playback as far as I can tell.
> 
> VLC_CODEC_LJPG is used only for encoder. For decoder, you must use
> MJPEG.

Welll no, that´s not how the core works (and nor how it ever worked AFAICT). 
You have to use the same FourCC set on both sides and rely on other parameters 
to constrain the encoders.

I really do not care if you prefer to treat them as two separate codecs (with 
different FourCC as now), or two separate profiles of the same codec (with the 
same FourCC as before). But you can´t have it both ways, at least not with the 
previous and the current APIs.

-- 
Rémi Denis-Courmont
http://www.remlab.net/