[vlc-devel] [PATCH] hls: fix inttypes include

Thomas Guillem thomas at gllm.fr
Mon Jun 15 11:27:29 CEST 2015


As we use C++11, the __STDC_*_MACROS defines shouldn't be needed
The problem is that C++11 in android is not up to date and need theses
defines. Maybe we should put these defines in vlc_fixups.h for ANDROID
and others OS that are not up to date. Or I can find a way to force
these defines from the android build script.

On Sun, Jun 14, 2015, at 00:26, Jean-Baptiste Kempf wrote:
> On 12 Jun, Rémi Denis-Courmont wrote :
> > Le 2015-06-12 13:30, Thomas Guillem a écrit :
> > >Maybe we should factorize all __STDC_*_MACROS defines in vlc_fixups.h
> > >instead of
> > >having these defines in each cpp file, no ?
> > 
> > It would be simpler but are you sure that there will never be a conflicting
> > definition in some C++ file that needs to be included in the future? (That's
> > why the macros exist in the first place.)
> We don't know about the future, but now, we have to add this to every
> C++ file and it's a bit bothersome to be honest.
> With my kindest regards,
> -- 
> Jean-Baptiste Kempf
> http://www.jbkempf.com/ - +33 672 704 734
> Sent from my Electronic Device
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

More information about the vlc-devel mailing list