[vlc-devel] [PATCH] gcrypt: require libgcrypt >= 1.6.0

[Thomas Guillem]

On Mon, Jun 15, 2015, at 10:48, Thomas Guillem wrote:
> 
> 
> On Fri, Jun 12, 2015, at 20:40, Rémi Denis-Courmont wrote:
> > Le vendredi 12 juin 2015, 16:02:30 Thomas Guillem a écrit :
> > > On Fri, Jun 12, 2015, at 15:44, Rémi Denis-Courmont wrote:
> > > > Le 2015-06-12 16:10, Thomas Guillem a écrit :
> > > > > And remove vlc_gcrypt.h that was used to setup thread callbacks since
> > > > > it's not supported anymore.
> > > > 
> > > > While the thread callbacks are gone, the global non-reentrant
> > > > initialization is still necessary.
> > > 
> > > Do we still need to call gcry_control (GCRYCTL_SET_THREAD_CBS,
> > > &gcry_threads_pthread); ?
> > 
> > No, obviously as it is now ignored. But the library still needs retarded  
> > explicitly serialized global initialization.
> 
> I don't understand, I don't see the "retarded explicitly serialized
> global initialization". The vlc_gcrypt_init function only does a 
> gcry_control (GCRYCTL_SET_THREAD_CBS, &gcry_threads_vlc);
> That's why I removed it and the whole file.

OK got it, any gcry_control call the global_init() in gcrypt that is not
thread safe.

> 
> > 
> > -- 
> > Rémi Denis-Courmont
> > http://www.remlab.net/
> > 
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel