[vlc-devel] [vlc-commits] hls: include config.h

[Rémi Denis-Courmont]

Le mercredi 17 juin 2015, 11:58:11 Hugo Beauzée-Luyssen a écrit :
> On 16/06/2015 10:51, Thomas Guillem wrote:
> > vlc | branch: master | Thomas Guillem <thomas at gllm.fr> | Mon Jun 15
> > 11:12:21 2015 +0200| [0ed21d151df2db4ee04d739878e2b842c5622256] |
> > committer: Thomas Guillem
> > 
> > hls: include config.h
> > 
> >> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=0ed21d151df2db4ee0
> >> 4d739878e2b842c5622256> 
> > ---
> > 
> >   modules/demux/hls/HLSManager.cpp |    4 ++++
> >   1 file changed, 4 insertions(+)
> > 
> > diff --git a/modules/demux/hls/HLSManager.cpp
> > b/modules/demux/hls/HLSManager.cpp index c5a0863..e098023 100644
> > --- a/modules/demux/hls/HLSManager.cpp
> > +++ b/modules/demux/hls/HLSManager.cpp
> > @@ -18,6 +18,10 @@
> > 
> >    * Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
> >    ***********************************************************************
> >    ******/> 
> > +#ifdef HAVE_CONFIG_H
> > +# include "config.h"
> > +#endif
> > +
> > 
> >   #include "HLSManager.hpp"
> >   #include "../adaptative/logic/RateBasedAdaptationLogic.h"
> >   #include "../adaptative/tools/Retrieve.hpp"
> 
> Hi,
> 
> Shouldn't this be done in the HLSManager.hpp?

This has been discussed a number of times already. The answer is No.

config.h must be included before any other header and can only be included 
once.

-- 
Rémi Denis-Courmont
http://www.remlab.net/