[vlc-devel] [vlc-commits] Revert "Fix warning on all c++ files"

Hugo Beauzée-Luyssen hugo at beauzee.fr
Mon Jun 22 16:02:12 CEST 2015


On 22/06/2015 16:00, Hugo Beauzée-Luyssen wrote:
> vlc | branch: master | Hugo Beauzée-Luyssen <hugo at beauzee.fr> | Mon Jun 22 16:00:24 2015 +0200| [0bcb7fd2567ba494b730234609b146cd8e23483c] | committer: Hugo Beauzée-Luyssen
>
> Revert "Fix warning on all c++ files"
>
> This reverts commit 59678ec0b489d86f6f62cc987e21a82346f8da42.
>
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=0bcb7fd2567ba494b730234609b146cd8e23483c
> ---
>
>   include/vlc_atomic.h |    5 -----
>   1 file changed, 5 deletions(-)
>
> diff --git a/include/vlc_atomic.h b/include/vlc_atomic.h
> index a652391..72590c8 100644
> --- a/include/vlc_atomic.h
> +++ b/include/vlc_atomic.h
> @@ -115,12 +115,7 @@ static inline void vlc_atomic_init_float(vlc_atomic_float *var, float f)
>   {
>       union { float f; uint32_t i; } u;
>       u.f = f;
> -#if defined(__cplusplus) && defined(HAVE_CXX11)
> -    vlc_atomic_float a(u.i)
> -    *var = a;
> -#else
>       atomic_init(var, u.i);
> -#endif
>   }
>
>   /** Helper to retrieve a single precision from an atom. */
>
> _______________________________________________
> vlc-commits mailing list
> vlc-commits at videolan.org
> https://mailman.videolan.org/listinfo/vlc-commits
>

Apologies for the screw up, this was obviously wrong, and even with the 
missing ';', it won't work since copy constructors are deleted for atomic<T>
Any opinions on removing this block entirely for C++?

-- 
Hugo Beauzée-Luyssen



More information about the vlc-devel mailing list