[vlc-devel] [vlc-commits] Remove using namespace std; from C++ code

[Jean-Baptiste Kempf]

On 22 Jun, Rémi Denis-Courmont wrote :
> Le lundi 22 juin 2015, 18:41:48 Jean-Baptiste Kempf a écrit :
> > On 22 Jun, Rémi Denis-Courmont wrote :
> > > Le lundi 22 juin 2015, 18:27:56 Jean-Baptiste Kempf a écrit :
> > > > On 22 Jun, Rémi Denis-Courmont wrote :
> > > > > It is "optional" in that the code will still compile in 1999 mode. But
> > > > > it
> > > > > makes C11 and C++11 atomic types mandatory.
> > > > 
> > > > I don't see why? Couldn't people use the fallback?
> > > 
> > > I don' think so. This has already been addressed both in the commit logs
> > > and in the mail thread.
> > 
> > What I understood from your email and the thread is that if we need to have
> > C11 and C++11 at the same time, in order to have "compatible definitions of
> > atomic types in C and C++". OK, I understand that.
> > 
> > But I don't see why we can't have no-C11/no-C++11 with fallbacks, or how
> > this february commit is different from when we had C11 atomics and
> > fallbacks as in 2.2.x.
> 
> The bug would "spontaneously" manifest if an hypothetical insane compiler 
> defaults to version 2011 of only one of the two languages, or if the compiler 
> flags are forced likewise. In that respect, the bug predates the switch to 
> C++11 in configure in latent form. It so happens that the switch was made 
> before any real life compiler or project started using version 2011.

So, can't we, if one of those two is missing, disable both and only use
our fallbacks?

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device