[vlc-devel] [PATCH] contrib/sidplay: fix openmode patch

[Hugo Beauzée-Luyssen]

On 23/06/2015 13:06, Felix Paul Kühne wrote:
> _Ios_Openmode is an implementation detail of the GNU c++ stdlib whereas ios_base::openmode is the portable way to go
> ---
>   contrib/src/sidplay2/sidplay2-openmode.patch | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/contrib/src/sidplay2/sidplay2-openmode.patch b/contrib/src/sidplay2/sidplay2-openmode.patch
> index 80a8e27..6e12d57 100644
> --- a/contrib/src/sidplay2/sidplay2-openmode.patch
> +++ b/contrib/src/sidplay2/sidplay2-openmode.patch
> @@ -7,7 +7,7 @@
>
>        // This sucks big time
>   -    openmode createAtrr = std::ios::in;
> -+    std::_Ios_Openmode createAtrr = std::ios::in;
> ++    std::ios_base::openmode createAtrr = std::ios::in;
>    #ifdef HAVE_IOS_NOCREATE
>        createAtrr |= std::ios::nocreate;
>    #endif
> @@ -16,7 +16,7 @@
>        {
>            // Open binary output file stream.
>   -        openmode createAttr = std::ios::out;
> -+        std::_Ios_Openmode createAttr = std::ios::out;
> ++        std::ios_base::openmode createAttr = std::ios::out;
>    #if defined(HAVE_IOS_BIN)
>            createAttr |= std::ios::bin;
>    #else
> @@ -25,7 +25,7 @@
>        {
>            // Open ASCII output file stream.
>   -        openmode createAttr = std::ios::out;
> -+        std::_Ios_Openmode createAttr = std::ios::out;
> ++        std::ios_base::openmode createAttr = std::ios::out;
>            if ( overWriteFlag )
>                createAttr |= std::ios::trunc;
>            else
> @@ -34,7 +34,7 @@
>        {
>            // Open binary output file stream.
>   -        openmode createAttr = std::ios::out;
> -+        std::_Ios_Openmode createAttr = std::ios::out;
> ++        std::ios_base::openmode createAttr = std::ios::out;
>    #if defined(HAVE_IOS_BIN)
>            createAttr |= std::ios::bin;
>    #else
>
Looks very sane to me.

Regards,

-- 
Hugo Beauzée-Luyssen